Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add coverage #290

Merged
merged 8 commits into from
Dec 29, 2024
Merged

feat: add coverage #290

merged 8 commits into from
Dec 29, 2024

Conversation

anhnd350309
Copy link
Contributor

@anhnd350309 anhnd350309 commented Dec 19, 2024 •
edited
Loading

Description

This PR introduces code coverage tracking to the project. Key additions include:

  • check coverage in CI-CD: example
Total Coverage: 25.05%
Coverage (25.05%) meets the threshold (20%).
  • If the coverage is less than 20%, the PR cannot be merged.
  • If you want to run in locally, run pnpm cd-test and check the coverage folder

Next Steps

  • Review and validate coverage thresholds
  • Ensure CI/CD pipeline integration for automated coverage checks.

@anhnd350309 anhnd350309 marked this pull request as ready for review December 23, 2024 03:40
@anhnd350309 anhnd350309 requested a review from d-roak as a code owner December 23, 2024 03:40
JanLewDev
JanLewDev approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@JanLewDev JanLewDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

trungnotchung
trungnotchung approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@trungnotchung trungnotchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

d-roak
d-roak reviewed Dec 23, 2024
View reviewed changes
check-coverage.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
vite.config.mts Outdated Show resolved Hide resolved
d-roak
d-roak approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@d-roak d-roak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-roak d-roak merged commit 87bb515 into main Dec 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungnotchung trungnotchung trungnotchung approved these changes

@JanLewDev JanLewDev JanLewDev approved these changes

@d-roak d-roak d-roak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anhnd350309 @d-roak @JanLewDev @trungnotchung